Boyden, Mark - Discussion

Boyden, Mark Forum Index

All Posts

Bottom Previous Topic Next Topic

(1) 2 »

#1 Re: download of modified modules

Mark Boyden Posted on: 2010/6/22 14:40

I have posted a number of them in the downloads area of this site. Is there a specific one you are looking for?

Topic | Forum

#2 Re: xcGallery

Mark Boyden Posted on: 2010/6/1 16:50

Sorry, I didn't provide a downloadable fix, I only provided the info in these messages.

DOUG: Editing a template in my directory using NoteTab Light.. then uploading back to the system.

DOUG: OH! .. Making sure I have this correct .. if I do an change to a template, I have to update?
So I would go and make a new module for the current one? and do an update? ..

Correct. There are two methods, realistically. OK, maybe three.

1. The really old way: update the file in templates (as you have done); update the module

2. Create a custom set of templates in the templates area. You do this by cloning the default set. Then, you can go into the system preferences and choose the template set you want to use (sort of like how themes are done). You can then edit these individually in the templates area.

3. Use the AltSys module from GIJoe which allows for much better management of blocks and templates IMHO. In the templates area it allows you to manage sets of templates and copy and replace and such real easily as well as compare the various versions and such. As you get into modifying templates in modules you'll really want to have this module. I'll note the blocks management in 2.5.0 of XOOPS is very promising, but it won't necessarily do everything this module does. I have an article on that module in here as well - purely administrative, but necessary.

Notes: However, with the changes I proposed that you have already made, updating the module with take care of the moment for you because it gets written to the default set whenever you update which is what the system uses. However, if you make ANY changes to templates, to make sure you don't lose them, clone the default set and then set the preferences to use the new set because if you update the module in the future, you will lose those updates.

Clear as mud?

Topic | Forum

#3 Re: xcGallery

texacoon Posted on: 2010/6/1 13:28

The "fix" I'm providing will not prevent access to that page nor the creation of albums. All it will do is prevent the ability to see the links to that page.

DOUG: Thanks! .. where would I download it at?

Can you explain the process you use to edit your templates? Are you using a custom set of templates? Are you editing a custom one, the default or the file in the module directory?

DOUG: Editing a template in my directory using NoteTab Light.. then uploading back to the system..

If you aren't using a custom set and you are editing the file in the module templates directory, then you have to update the module before the default set is updated. My recommendation is to use the AltSys module and create a custom set of templates, set those active in your system preferences and then edit those because every time you update a module the default set is overwritten with the file set.

DOUG: OH! .. Making sure I have this correct .. if I do an change to a template, I have to update?
So I would go and make a new module for the current one? and do an update? ..

I've made it work for me at this point, but I can't see all of your setup, but assuming that the test user is indeed ONLY a registered user, then I would expect to not see the links but only if the template is correct.

DOUG: That's correct .. The Test is for a regular user .. does not have admin capabilites..

Topic | Forum

#4 Re: xcGallery

Mark Boyden Posted on: 2010/6/1 10:50

The "fix" I'm providing will not prevent access to that page nor the creation of albums. All it will do is prevent the ability to see the links to that page.

Can you explain the process you use to edit your templates? Are you using a custom set of templates? Are you editing a custom one, the default or the file in the module directory? If you aren't using a custom set and you are editing the file in the module templates directory, then you have to update the module before the default set is updated. My recommendation is to use the AltSys module and create a custom set of templates, set those active in your system preferences and then edit those because every time you update a module the default set is overwritten with the file set.

I've made it work for me at this point, but I can't see all of your setup, but assuming that the test user is indeed ONLY a registered user, then I would expect to not see the links but only if the template is correct.

Topic | Forum

#5 Re: xcGallery

texacoon Posted on: 2010/6/1 10:37

Mark ...

LOL! ... Man-O-me ..
I did exactly as you stated .. I even tested to see if I could add an album and sure enough I did ..

The buttons were still displayed in both ADMIN and REG Member.

This is really stranged how it doesnt seem to cooperate ..
Did take out the footer as you stated.. OH YES much cleaner.

Doug

Topic | Forum

#6 Re: xcGallery

Mark Boyden Posted on: 2010/6/1 8:53

You'll notice that at the top of the pages it loads the xcgal_header.html template in the pages. That is where the button code is. Here is some code that should get rid of it. In the xcgal_header.html template, change (about 10 lines from the bottom):

<{if $admin_mode==1}>

to:

<{if $admin_mode==1 && $xoops_isadmin}>

That should take care of it for you (will remove display for registered users and leave it for module administrators).

I'll note that I totally redid almost all of the templates for this module (as I tend to do for almost every module). I also changed those buttons to simple links among other things (buttons weren't necessary).

You might also want to take the xcG/dev.xoops.org attribution out of the xcgal_footer.html, but that is up to you. Beyond learning to install and configure modules, learning to manipulate templates and learning Smarty is another powerful step for XOOPS admins. It's just HTML, generally.

Topic | Forum

#7 Re: xcGallery

texacoon Posted on: 2010/5/31 21:40

Well .. tried both and nothing ... did not remove the two buttons ...

I did take a look at xcgal_albmgr.html ... Seems there are is some missing info in the script .. If you have time, see what you think .. Still a newbie on this end, yet when something doesnt quite read right I like to have a second opinion before I start making changes ....

Did fix my user test on the site if you would like to try it again ..
Matter of fact didnt realize your from Austin Tx ... I may be headed to your area this upcoming weekend ... My folks live in Temple .. I'm originally from Corpus Christi ..
Small world ..LOL!



<{include file="db:xcgal_header.html"}>

<script language="javascript">

<!--

    function CheckAlbumForm(frm)

    {

        var select_len = frm.to.length;

        var album = new Object();

        var changed = false;



        for (i=0; i<select_len; i++) {

            album = new parseSelectValue(frm.to, i);



            if (album.action != '0') {

                if (album.album_nm == '') {

                    alert('<{$alb_need_name}>');

                    frm.to.options[i].selected = true;

                    return false;

                }

                changed = true;

            }

        }



        if (frm.delete_album.value.len !=0)

            changed = true;



        if (changed) {

            if (confirm('<{$confirm_modifs}>')) {

                for (i=0; i<select_len; i++) {

                    album = new parseSelectValue(frm.to, i);

                    if (album.action != '0') {

                        frm.to.options[i].selected = true;

                    }

                }

                return true;

            }

            else

                return false;

        }

        else {

            alert('<{$no_change}>');

            return false;

        }

    }



    function page_init()

    {

        document.album_menu.delete_album.value = "";

    }

-->

</script>



<script language="javascript">

<!--

    var selectedOptIndex;



    function Album_Select(selectedIndex)

    {

        selectedOptIndex = selectedIndex;



        for (i=0; i<document.album_menu.to.length; i++) {

            document.album_menu.to.options[i].selected = false;

        }

        document.album_menu.to.options[selectedIndex].selected = true;



        var album = new Object();

        album = new parseSelectValue(document.album_menu.to, selectedIndex);



        album.deleteFrm();

        album.changeFrm();

    }



    function Moveup_Option()

    {

        var to = document.album_menu.to;

        var pos = selectedOptIndex;

        if (pos == 0) {

            return;

        }



        swap_option(to, pos, pos-1);

        selected_option(to, pos-1);

    }



    function Movedown_Option()

    {

        var to = document.album_menu.to;

        var pos = selectedOptIndex;

        if (pos == to.length-1) {

            return;

        }



        swap_option(to, pos, pos+1);

        selected_option(to, pos+1);

    }



    function Album_Create()

    {

        var prev_album;

        var to_pos, album_type, album_sort;

        var to = document.album_menu.to;



        if (to.selectedIndex == -1)

            to_pos = to.length;

        else

            to_pos = to.selectedIndex;



        if (to_pos > 0) {

            prev_album = new parseSelectValue(to, to_pos-1);

            album_sort = Number(prev_album.album_sort)+1;

        }

        else {

            album_sort = 1;

        }

        move_list (to, to_pos);

        make_option("<{$new_album}>", make_value('0', "<{$new_album}>", album_sort, '1'), to, to_pos);



        selected_option(to, to_pos);

    }



    function Album_Delete()

    {

        var album = new Object();

        var to = document.album_menu.to;

        album = new parseSelectValue(to, selectedOptIndex);



        var msg = '<{$confirm_delete1}>';



        if (album.action == '1') {

            if (confirm(msg)) {

                to.options[selectedOptIndex] = null;

                document.album_menu.album_nm.value='';

            }

            else {

                return;

            }

        }

        else {

            msg = msg + '<{$confirm_delete2}>';



            if (confirm(msg)) {

                var album = new Object();

                album =  new parseSelectValue(to, selectedOptIndex);

                to.options[selectedOptIndex] = null;

                document.album_menu.album_nm.value='';



                document.album_menu.delete_album.value = document.album_menu.delete_album.value + album.album_no + ',';

            }

            else {

                return;

            }

        }

    }



    function Album_NameChange(change_name)

    {



        try {

            var album = new Object();

            var to = document.album_menu.to;

            var value;

            var text;



            album = new parseSelectValue(to, selectedOptIndex);

            if (album.action == '1')

                action = '1';

            else

                action = '2';



            text = change_name.substring(0, 80);

            value = make_value(album.album_no, change_name, album.album_sort, action);

            make_option(text, value, to, selectedOptIndex);

        }

        catch(e) {

            alert("<{$select_first}>");

        }

    }



    function make_option(text, value, target, index)

    {

        target[index] = new Option(text, value);

    }



    function move_list(target, pos)

    {

        var album = new Object();

        var listlen = target.length;



        for (j=listlen-1; j>pos-1; j--) {

            album = new parseSelectValue(target, j)

            if (album.action == '1') {

                value = make_value(album.album_no, album.album_nm, Number(album.album_sort)+1, '1');

            }

            else {

                value = make_value(album.album_no, album.album_nm, Number(album.album_sort)+1, '2');

            }

            text  = target.options[j].text;



            make_option(text, value, target, j+1);

        }

    }



    function _private_update_frm_element(name)

    {

        var frm = document.album_menu;

        frm.album_nm.value = name;

    }



    function _private_change()

    {

        _private_update_frm_element(this.album_nm);

    }



    function _private_delete()

    {

        _private_update_frm_element('');

    }



    function parseSelectValue(select, selectedIndex)

    {

        var temp_nm

        var option_value = select.options[selectedIndex].value;



        this.album_no = option_value.substring(option_value.indexOf('album_no=') + 9, option_value.indexOf(','));

        option_value = option_value.substring(option_value.indexOf(',') + 1);



        temp_nm = option_value.substring(option_value.indexOf('album_nm=') + 9, option_value.indexOf('album_sort=')-1);

        this.album_nm = temp_nm.substring(1, temp_nm.length-1);

        option_value = option_value.substring(option_value.indexOf('album_sort='));



        this.album_sort = option_value.substring(option_value.indexOf('album_sort=') + 11 ,option_value.indexOf(','));

        option_value = option_value.substring(option_value.indexOf(',') + 1);



        this.action = option_value.substring(option_value.indexOf('action=') + 7);



        this.changeFrm = _private_change;

        this.deleteFrm = _private_delete;



        return this;

    }



    function selected_option(target, pos)

    {

        target.options[pos].selected = true;

        Album_Select(pos);

    }



    function swap_option(target, swap_a, swap_b)

    {

        var album_a = new Object();

        var album_b = new Object();



        album_a = new parseSelectValue(target, swap_a);

        album_b = new parseSelectValue(target, swap_b);



        if (album_a.action == '0') album_a.action = '2';

        if (album_b.action == '0') album_b.action = '2';



        var temp_option = new Option(target.options[swap_a].text, make_value(album_a.album_no, album_a.album_nm,album_b.album_sort,album_a.action));

        target[swap_a] = new Option(target.options[swap_b].text, make_value(album_b.album_no, album_b.album_nm,album_a.album_sort,album_b.action));

        target[swap_b] = temp_option;

    }



    function make_value(album_no, album_nm, album_sort, action)

    {

        return "album_no=" + album_no + ",album_nm='" + album_nm + "',album_sort=" + album_sort + ",action=" + action;

    }

-->

</script>

<form name="album_menu" method="post" style="margin: 0; padding: 0;" action="delete.php?what=albmgr" onSubmit="return CheckAlbumForm(this);">

<table border="0" align="center" width="100%" cellspacing="1" cellpadding="0" class="outer">

  <tr>

    <th><h2><{$alb_mrg}></h2></th>

  </tr>

  <tr>

    <td class="odd" valign="top" align="center">

        <input type="hidden" name="delete_album" value="" />

        <input type="hidden" name="sort_order" value="<{$sort_order}>" />

        <br />

        <table style="width: 300px" width="300" border="0" cellspacing="0" cellpadding="0">

          <{if $admin_mo==1}>

          <tr>

            <td>

              <b><{$select_category}></b>

              <select onChange="if(this.options[this.selectedIndex].value) window.location.href='albmgr.php?cat='+this.options[this.selectedIndex].value;"  name="cat" class="listbox">

                <{$options}>

              </select>

              <br /><br />

            </td>

        </tr>

        <{/if}>

        <tr>

            <td>

              <select id="to" name="to[]" size="<{$size}>" multiple="multiple" onChange="Album_Select(this.selectedIndex);" class="listbox2" style="width: 300px;">

               <{$lb}>

              </select>

            </td>

        </tr>

        <tr>

            <td>

                <table style="width: 300px;text-align: left;" border="0" cellspacing="0" cellpadding="0">

                <tr>

                    <td><a href="javascript:Moveup_Option();"><img src="images/move_up.gif" width="26" height="21" border="0" alt=""/></a><a href="javascript:Movedown_Option();"><img src="images/move_down.gif" width="26" height="21" border="0" alt=""/></a>

                    </td>

                    <td align="center" style="background-color: #D4D0C8; width: 80px; height: 21px; border-top: 1px solid White; border-left: 1px solid White; border-right: 1px solid #808080; border-bottom: 1px solid #808080;"><a href="javascript:Album_Delete();" style="color: Black; font-weight: bold;"><{$delete}></a>

                    </td>

                    <td align="center" style="width: 1px;"><img src="images/spacer.gif" width="1" alt=""/><br />

                    </td>

                    <td align="center" style="background-color: #D4D0C8; width: 80px; height: 21px; border-top: 1px solid White; border-left: 1px solid White; border-right: 1px solid #808080; border-bottom: 1px solid #808080;"><a href="javascript:Album_Create();" style="color: Black; font-weight: bold;"><{$new}></a>

                    </td>

                </tr>

                </table>

            </td>

        </tr>

        <tr>

            <td><br />

                <input type="text" name="album_nm" size="27" maxlength="80" class="textinput" style="width: 300px;" onChange="Album_NameChange(this.value);" onKeyUp="Album_NameChange(this.value);" />

                <br />

                <br />

            </td>

        </tr>

        </table>

    </td>

</tr>

<tr>

    <td colspan="2" align="center" class="foot">

    <input type="submit" class="button" value="<{$apply_modifs}>" />

    </td>



</tr>

</table></form>

<{include file="db:xcgal_footer.html"}>

Topic | Forum

#8 Re: xcGallery

Mark Boyden Posted on: 2010/5/31 21:02

I logged in using test/test and it gave an incorrect login. not sure what happened there.

As to the X vs 1, X was whatever category ID you're trying to not display. If the Member Albums is indeed category 1 (as it should and sounds like it was) then the code I gave you should work. However, that was for the menus block.

What you want is for the main photo pages, I'm guessing based on looking at your info. For that, you'll need to edit the xcgal_header.html template. Probably easiest to just remove the link(s) near the bottom of that template. That, or add the xoops_isadmin to the if statement.

Topic | Forum

#9 Re: xcGallery

texacoon Posted on: 2010/5/31 18:52

Ok .. took a look .. Cat ID showed 1 .. tried an X and still not fixing the issue ..

Go to http://www.nebcn.org/portal/modules/xcgal/modifyalb.php

login as test with password as test .. my site is not open to the public at this time ..
Maybe you can see how this xcgal is still can go into the Album Manager just a registered member .. If you log out then you dont see it .. I do like the idea that the only admin can see the Album Manager ..

Any of these two Create / order my albums - Modify my albums or still seen and operational for a registered user..

Topic | Forum

#10 Re: xcGallery

Mark Boyden Posted on: 2010/5/31 17:34

Hmmmm. It works on my setup. Make sure the category id (cat=X in the URL) is 1. You may be missing a different category for the users.

Essentially all I added was code that says, if the categoryID isn't 1 (automatically created when installed for the member albums) or if you are an administrator of the photos module, then you will see the link; otherwise you won't.

So, make sure that links is to category ID 1. If not, change the template code to be <> X, where X is that particular category ID. This is obfuscation, not depermissioning.

Also, make sure you have cleared your cache and such as well.

Topic | Forum

Top

(1) 2 »